This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 298
feat(order/filter,topology/instances/nnreal): upgrade some lemmas to iff
#18964
Open
urkud
wants to merge
4
commits into
master
Choose a base branch
from
YK-comap-ite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
modifies-synchronized-file
This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR.
label
May 7, 2023
urkud
added
t-topology
Topological spaces, uniform spaces, metric spaces, filters
t-order
Order hierarchy
labels
May 7, 2023
eric-wieser
reviewed
May 7, 2023
eric-wieser
reviewed
May 7, 2023
eric-wieser
reviewed
May 7, 2023
eric-wieser
reviewed
May 8, 2023
@@ -320,6 +320,18 @@ calc a ⊓ x ≤ (b ⊔ y) ⊓ x : inf_le_inf hle le_rfl | |||
lemma le_sup_right_iff_inf_left_le {a b} (h : is_compl x y) : a ≤ b ⊔ y ↔ a ⊓ x ≤ b := | |||
⟨h.inf_left_le_of_le_sup_right, h.symm.dual.inf_left_le_of_le_sup_right⟩ | |||
|
|||
lemma sup_inf_sup_eq (h : is_compl x y) : (a ⊔ x) ⊓ (b ⊔ y) = (b ⊓ x) ⊔ (a ⊓ y) := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think sup_inf_sup_comm
is the standard name for this type of thing, though usually we'd order it as
Suggested change
lemma sup_inf_sup_eq (h : is_compl x y) : (a ⊔ x) ⊓ (b ⊔ y) = (b ⊓ x) ⊔ (a ⊓ y) := | |
lemma sup_inf_sup_comm (h : is_compl a d) : (a ⊔ b) ⊓ (c ⊔ d) = (a ⊓ c) ⊔ (b ⊓ d) := |
Maybe it's convenient to have both
kim-em
added
the
awaiting-author
A reviewer has asked the author a question or requested changes
label
Jun 5, 2023
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
awaiting-author
A reviewer has asked the author a question or requested changes
modifies-synchronized-file
This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR.
t-order
Order hierarchy
t-topology
Topological spaces, uniform spaces, metric spaces, filters
too-late
This PR was ready too late for inclusion in mathlib3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codisjoint.inf_left_sup_inf_right
andis_compl.le_inf_sup_inf
.filter.comap_ite
,filter.comap_max
, andfilter.tendsto_ite
.real.map_to_nnreal_at_top
,real.comap_to_nnreal_at_top
, andreal.tendsto_to_nnreal_at_top_iff
.tendsto_real_to_nnreal
tofilter.tendsto.real_to_nnreal
so that it can be used with dot notation.
ennreal.tendsto_of_real_nhds_top
.I'm cleaning up old local branches. I don't remember why I wanted to
have these lemmas but IMHO upgrading from implications to
iff
s is agood thing.