Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small refinements about field theory galois #20217

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Thmoas-Guan
Copy link
Collaborator

Small refinements about Fieldtheory.Galois
Mainly about few refine in proof style and some more suggested lemma.


Open in Gitpod

add lemma isOpen_and_normal_iff_finite_and_isGalois

refien proof of galoisCoinsertionIntermediateFieldSubgroup
@Thmoas-Guan Thmoas-Guan added the t-algebra Algebra (groups, rings, fields, etc) label Dec 24, 2024
Copy link

github-actions bot commented Dec 24, 2024

PR summary e9d1afb635

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ isOpen_and_normal_iff_finite_and_isGalois

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant