Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Extending convex functions #6339
[Merged by Bors] - feat: Extending convex functions #6339
Changes from 7 commits
68d8c1c
8063ff2
89c3766
d709c9a
3d82c87
cef3191
26118c2
698e75b
40a024b
f5332a0
e4d1aa7
ede0969
fc49843
82f4495
b476ebb
d45cd35
14a7c4c
db766ae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check notice on line 8 in Mathlib/Algebra/Order/Module.lean
GitHub Actions / Add annotations
Synchronization
Check notice on line 11 in Mathlib/Algebra/Order/Monoid/Lemmas.lean
GitHub Actions / Add annotations
Synchronization
Check notice on line 14 in Mathlib/Algebra/Order/SMul.lean
GitHub Actions / Add annotations
Synchronization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is new, right? If so, can you drop it from this PR so that it can be reviewed as a port, not a forward-port?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is a forward-port, though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only a forward-port if it's a modification of a file that was already ported from the out-of-sync region of https://leanprover-community.github.io/mathlib-port-status; otherwise it's just a sparkling port.
It's best to do this in a separate PR using
start_port.sh
so that the review against mathport is possible. Obviously that will have to wait for the rest of this files in this PR to be merged first.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you recently change the presentation of
out-of-sync
? I swear I copied that code from there 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't touched it...