Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Extending convex functions #6339
[Merged by Bors] - feat: Extending convex functions #6339
Changes from 15 commits
68d8c1c
8063ff2
89c3766
d709c9a
3d82c87
cef3191
26118c2
698e75b
40a024b
f5332a0
e4d1aa7
ede0969
fc49843
82f4495
b476ebb
d45cd35
14a7c4c
db766ae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check notice on line 8 in Mathlib/Algebra/Order/Module.lean
GitHub Actions / Add annotations
Synchronization
Check notice on line 12 in Mathlib/Algebra/Order/Monoid/Lemmas.lean
GitHub Actions / Add annotations
Synchronization
Check notice on line 14 in Mathlib/Algebra/Order/SMul.lean
GitHub Actions / Add annotations
Synchronization
Check notice on line 9 in Mathlib/Data/Set/Intervals/Basic.lean
GitHub Actions / Add annotations
Synchronization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the other three lemmas,
MonotoneOn.image_Icc_subset
,AntitoneOn.image_Icc_subset
, andAntitone.image_Icc_subset
? I'm a bit confused, because your previous version had maybe 20 new lemmas, but this one is now missing 3 lemmas.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two approaches come to mind:
#noalign
s for the other three lemmas with a TODO commentThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went for the second because it's less work for me: #7146.
Check notice on line 12 in Mathlib/Order/Lattice.lean
GitHub Actions / Add annotations
Synchronization