-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a step that logs the version of lake and lean #24
Conversation
Give me some feedback about precisely what behaviour is required and I can modify this.
|
This PR looks great! This will allow existing projects such as import-graph to simplify their workflow even more by using I have a suggestion that might improve the user experience, though it deviates slightly from the original issue. Since some Lean setup happens during
If we decide to go this route, we could potentially omit the Mathlib check logging since the Let me know what you think! |
I like your plan, simplicity is a good thing. |
😱 I'm sorry! I'm perfectly aware of this issue with the paths in gh actions and I also thought I was testing each thing I did before opening the PR. However it appears that I wasn't capable of anything sensible late on Friday after a long week. I'll mend it carefully soon. Probably simplest to just add the paths to each command, e.g., |
I've updated these two lines to log the version. I tested it on a test repo and it does as expected. |
Looks great. Thanks @oliver-butterley! |
Add a step to the action which:
resolves #12