Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename mathlib-cache -> get-mathlib-cache and improve interface #29

Merged
merged 1 commit into from
May 19, 2024

Conversation

austinletson
Copy link
Collaborator

Improve the user interface for detecting a Mathlib dependency and running lake exe cache get.

Rename mathlib-cache -> get-mathlib-cache.
Rename default value for get-mathlib-cache from empty string -> "auto".

@austinletson austinletson linked an issue May 17, 2024 that may be closed by this pull request
@austinletson austinletson force-pushed the 25-inconsistency-with-mathlib-cache-input branch from a150dd7 to 2b9013e Compare May 18, 2024 23:08
@oliver-butterley
Copy link
Contributor

For me this improved naming makes the functionality very clear.

@austinletson
Copy link
Collaborator Author

👍 Thanks for flagging this.

@austinletson austinletson merged commit 0d2b90f into main May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency with mathlib-cache input
2 participants