Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lake check-test check before running lake test #31

Merged

Conversation

austinletson
Copy link
Collaborator

Check for a test runner before running lake test with lake check-test.

Add a step summary when lake check-test fails.

@austinletson austinletson linked an issue May 18, 2024 that may be closed by this pull request
@austinletson
Copy link
Collaborator Author

I tested this on a test repo here. The summaries seem useful for surfacing important details.

2024-05-17-16:11:34-screenshot

@oliver-butterley
Copy link
Contributor

The summaries seem useful for surfacing important details.

🎉 Yes, a concise but complete and well formatted build summary would be very useful (at least in all the applications I can imagine). It can include basic info for each step that is run so the user of the action can easily confirm what happened. On failure the entry in the list for the given step can include info concerning the failure.

Related but separate design decision: run later steps to generate feedback even if earlier steps fail? Then fail at the end. E.g., reservoir eligibility can still be checked even if linting fails. Markdown formatted job summary can include ticks at each of the steps which have already passed and notes for the steps that have failed. Could mean that reviewing and improving PRs can be done in fewer cycles.

@austinletson austinletson force-pushed the 26-use-lake-check-test-to-detect-absence-of-a-test-runner branch from dd672a2 to 6f878c8 Compare May 21, 2024 11:20
@austinletson austinletson merged commit 355c18c into main May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use lake check-test to detect absence of a test runner
2 participants