refactor: Array.feraseIdx: avoid have in definition #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise it remains in the equational theorem and may cause the “unused have linter” to trigger. By moving the proof into `decreasing_by`, the equational theorems are unencumbered by termination arguments. see also leanprover-community/batteries#690 (comment)
nomeata
changed the title
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
|
What are the chances that this is fixed in the equation compiler so that it doesn't generate terms that violate the unused have linter? |
|
That's plausible; it would entail removing unused The induction principle generator should then also remove them from the minor premises. Do you see a case where the user might genuinely want then to be there in the equations? In some cases it maybe might be nice to have them in the goal to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise it remains in the equational theorem and may cause the
“unused have linter” to trigger. By moving the proof into
decreasing_by, the equational theorems are unencumbered by terminationarguments.
see also leanprover-community/batteries#690 (comment)