-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve error messages for level metavariables #4450
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Jun 14, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 14, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 14, 2024
leanprover-community-mathlib4-bot
added
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
release-ci
Enable all CI checks for a PR, like is done for releases
labels
Jun 14, 2024
Mathlib CI status (docs):
|
Should I create a new PR in order to get mathlib CI working again? (I merged with a more recent version of |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 19, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 19, 2024
Thank you for the PR but this is a lot of new code for a somewhat niche issue. We are not currently ready to maintain this code and as always, starting with smaller PRs further away from the foundation is the way to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
release-ci
Enable all CI checks for a PR, like is done for releases
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
def
/theorem
contains a metavariable, an error is thrown at the correct syntax, showing the context of the metavariable, and some text depending on whether the metavariable is implicit, or a placeholder.However, when there is a universe metavariable, this doesn't work as nicely, and an error is thrown at the start of the (mutual) definition. This is confusing because it doesn't point the user to the code causing the error, and it can confuse people who don't know much about universe levels.
So, I've implemented errors for universe levels analogously to expression metavariables. And when there are errors for both kinds of metavariables, then both errors are thrown, with the expression metavariable errors being logged first.
The errors for expression metavariables start with
So analogously the errors for universe metavariables start with
I would suggest to replace
don't know how to
withfailed to
as it means the same, but is shorter. I also would suggest using the wordinfer
instead ofsynthesize
, because we don't was to confuse this with type class synthesis errors.To implement this, I removed the code that turns level metavariables into level parameters in the values of the predefinitions, and I removed the function
checkForHiddenUnivLevels
, which is what throws the current universe errors. Then, I extended the functionlogUnassignedUsingErrorInfos
to also include the new level metavariable errors.A nice side effect is that the silently failing example at #2226 now isn't silent anymore. This is because the error thrown at
checkForHiddenUnivLevels
wasn't visible (due to being athrowError
, and not alogError
, as evidenced by #4463)