Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve error messages for level metavariables #4450

Closed
wants to merge 15 commits into from

Conversation

JovanGerb
Copy link
Contributor

@JovanGerb JovanGerb commented Jun 14, 2024

When a def/theorem contains a metavariable, an error is thrown at the correct syntax, showing the context of the metavariable, and some text depending on whether the metavariable is implicit, or a placeholder.

However, when there is a universe metavariable, this doesn't work as nicely, and an error is thrown at the start of the (mutual) definition. This is confusing because it doesn't point the user to the code causing the error, and it can confuse people who don't know much about universe levels.

So, I've implemented errors for universe levels analogously to expression metavariables. And when there are errors for both kinds of metavariables, then both errors are thrown, with the expression metavariable errors being logged first.

The errors for expression metavariables start with

don't know how to synthesize implicit argument
don't know how to synthesize placeholder

So analogously the errors for universe metavariables start with

don't know how to synthesize universe {levelName} of '{constName}'
don't know how to synthesize universe placeholder

I would suggest to replace don't know how to with failed to as it means the same, but is shorter. I also would suggest using the word infer instead of synthesize, because we don't was to confuse this with type class synthesis errors.

To implement this, I removed the code that turns level metavariables into level parameters in the values of the predefinitions, and I removed the function checkForHiddenUnivLevels, which is what throws the current universe errors. Then, I extended the function logUnassignedUsingErrorInfos to also include the new level metavariable errors.

A nice side effect is that the silently failing example at #2226 now isn't silent anymore. This is because the error thrown at checkForHiddenUnivLevels wasn't visible (due to being a throwError, and not a logError, as evidenced by #4463)

@JovanGerb JovanGerb marked this pull request as draft June 14, 2024 00:40
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 14, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 14, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 14, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan release-ci Enable all CI checks for a PR, like is done for releases labels Jun 14, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

@JovanGerb
Copy link
Contributor Author

Should I create a new PR in order to get mathlib CI working again? (I merged with a more recent version of nightly-with-mathlib)

@JovanGerb JovanGerb marked this pull request as ready for review June 19, 2024 02:22
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 19, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 19, 2024
@Kha
Copy link
Member

Kha commented Aug 26, 2024

Thank you for the PR but this is a lot of new code for a somewhat niche issue. We are not currently ready to maintain this code and as always, starting with smaller PRs further away from the foundation is the way to go.

@Kha Kha closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants