feat: staged CMake build with Lake as a plugin #6929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Feb 3, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 3, 2025
leanprover-community-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
|
@Kha Due to naming constraints I did not reuse |
|
I think we should just strip |
|
@Kha |
|
Right, I suppose so. I don't see a downside at least, these would be weird prefixes/suffixes for a module name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR passes the previous stages Lake as a plugin to the next stage's Lake in the CMake build. This enables Lake to use its own builtin elaborators / initializers at build time.
The Lake plugin is stored as
lib/lean/Lake.(dll|dynlib|so), which is just a copy of the Lake shared library (libLake_shared). The shared library cannot be used directly because its naming scheme is not compatible with--plugin(which requires the module name and library name to match exactly).