Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade expo to sdk 46 #124

Merged
merged 4 commits into from
Aug 20, 2022
Merged

upgrade expo to sdk 46 #124

merged 4 commits into from
Aug 20, 2022

Conversation

jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented Aug 16, 2022 •
edited
Loading

To test this PR do the following

$ git checkout upgrade-expo
$ meteor npm install
$ meteor npm run test # run jest tests
$ meteor npm run start # run the app via expo go

This also introduced a breaking change: Constants.manifest.extra is not readable in jest tests anymore so it's now moved out of app.json into settings.json.

@jankapunkt jankapunkt linked an issue Aug 17, 2022 that may be closed by this pull request
Update expo and dependencies #118
Closed
@jankapunkt jankapunkt merged commit beb8c08 into main Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliyildiz1 maliyildiz1 maliyildiz1 approved these changes

@turndownfawad turndownfawad Awaiting requested review from turndownfawad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update expo and dependencies
2 participants
@jankapunkt @maliyildiz1