Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-QC catalog should not include the stores that actually passed QC #28

Closed
jbusecke opened this issue Aug 29, 2023 · 1 comment
Closed

Comments

@jbusecke
Copy link
Collaborator

The way we have the cataloging set up right now causes all written stores to be written to the noqc catalog file.
It would be better to filter those out here so that the noqc catalog only contains iids that did not actually pass the tests.

@jbusecke
Copy link
Collaborator Author

In #89 I introduced some simplified logic which is based on a single bq table (#90). This now produces three different csv's:

  • A quality-controlled (tests passed, not retracted)
  • A non-quality-controlled (tests failed, not retracted)
  • A retracted (test whatever, retracted)

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant