simple gas simulations for rollups #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheReturnOfJan
previously approved these changes
Feb 27, 2020
|
|
||
| require('./helpers/setup'); | ||
|
|
||
| const Bridge = artifacts.require('RollupBridge'); |
There was a problem hiding this comment.
Next time call it RollupBridge hehe. I know this is not getting merged, but it is a good opportunity to write something and prove I actually reviewed this. 💯
|
|
||
| const rsp = await bridge.submitPeriodWithData(prevPeriodHash, newPeriodHash, block.hex()).should.be.fulfilled; | ||
| console.log(rsp.receipt.gasUsed); | ||
| // assert.equal(rsp.receipt.gasUsed, 738140); |
There was a problem hiding this comment.
Is the number correct here? Why is it commented out?
There was a problem hiding this comment.
Ok I think I see. You just used these to collect data. Disregard.
|
Looks good. Just 2 comments:
But overall, very nice 👍 P.S.: Real man use matplotlib to plot data |
|
Also one more thing: you could have probably pushed the data into an array during tests and then use something like plotly and have a plot automatically. Just FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rosolves #273
steps:
measurement results:
https://docs.google.com/spreadsheets/d/1ywhXffNw3sNzngvblu4hxE6d2ZbSQ_GjN2JFfl3vYFc/edit