Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android 32-bit build #1006

Merged
merged 4 commits into from
Oct 17, 2016
Merged

Fix Android 32-bit build #1006

merged 4 commits into from
Oct 17, 2016

Conversation

jdonald
Copy link
Contributor

@jdonald jdonald commented Oct 12, 2016

Here's the fix that @yeswalrus recommended, using stringstream.

I've clarified the preprocessor conditions so we have one less issue when eventually upgrading from gnustl to libc++.

Travis doesn't build Android yet, so I verified both 32-bit and 64-bit builds locally.

@jdonald jdonald added the bug label Oct 12, 2016
@jdonald jdonald added this to the v1.0.4 milestone Oct 12, 2016
@jdonald jdonald closed this Oct 17, 2016
@jdonald jdonald reopened this Oct 17, 2016
@hham hham self-assigned this Oct 17, 2016
@yeswalrus
Copy link
Contributor

@hham I checked MSVC, as soon as you verify this fixes the android 32 bit builds it should be good to go.

@hham
Copy link
Contributor

hham commented Oct 17, 2016

Oh good. I was building on my Windows laptop.

@hham hham merged commit af9e1bd into master Oct 17, 2016
@hham hham deleted the fix-android32 branch October 17, 2016 20:43
@jdonald
Copy link
Contributor Author

jdonald commented Oct 17, 2016

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants