Restore <autowiring/signal.h> #1008
Conversation
yeswalrus
force-pushed
the
feature-signal-header
branch
from
3c2aa60 to
e79a23e
Compare
| @@ -244,7 +245,7 @@ target_include_directories( | |||
| "${PROJECT_SOURCE_DIR}/contrib/autoboost" | |||
| PUBLIC | |||
| "$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/src>" | |||
| "$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>" | |||
| "$<BUILD_INTERFACE:${PROJECT_BUILD_DIR}/src>" | |||
There was a problem hiding this comment.
This causes a build error, "AutowiringVersion.h: No such file or directory."
There was a problem hiding this comment.
It's passing on Travis though . I have tested both in-source and out-of-source builds.
What are the steps to reproduce the error you're seeing?
There was a problem hiding this comment.
I made autowiring-build directory and ccmake ../autowiring inside the directory. PROJECT_BUILD_DIR is null in my Mac and Linux box.
There was a problem hiding this comment.
Fixed. Hyoung and I figured it out it was working on Travis only because that tests in-source builds.
|
Build fails. It seems to be from travis setting. My local build is successful. |
|
I've pushed a new fix that seems to work for Travis's in-source build. Please try it out on your out-of-source build environment. |
|
Builds fine in my local machine and travis. |
While
<signal.h>can be confusing as it shares its name with a standard UNIX header, it's explicit enough when customers#include <autowiring/signal.h>We have good reason for calling it
<autowiring/signal.h>as outlined in #851 when this was first added. Furthermore, I don't want to make a breaking change forcing us to autowiring-1.1.The problem we had to work around in #998 is properly dealt with by not adding all the dangerous include paths.