Fix a compiler error on VS2017 #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d for tuple due to changes in parameter expansion logic
jdonald
reviewed
Jan 6, 2018
| @@ -21,6 +21,12 @@ if(NOT MSVC OR MSVC_VERSION LESS 1900) | |||
| ) | |||
| endif() | |||
|
|
|||
| # Enable conformance mode for newer versions of MSVC | |||
There was a problem hiding this comment.
/d1parsePackExpressions- does not enable conformance mode (under Project Settings -> C/C++ -> Language). It only affects the new code for fold expressions.
We should either update the comment or the option. It might make sense to use /permissive- if we can. We'd like to switch platform over to conformance mode soon and autowiring could be a good first step.
jdonald
reviewed
Jan 6, 2018
CMakeLists.txt
Outdated
| string(APPEND CMAKE_CXX_FLAGS " /d1parsePackExpressions-") | ||
| endif() | ||
|
|
||
|
|
jdonald
reviewed
Jan 16, 2018
src/autowiring/C++11/filesystem.h
Outdated
| namespace awfsnamespace = std::experimental::filesystem; | ||
| #elif _MSC_VER >= 1900 | ||
| namespace awfsnamespace = std::tr2::sys; | ||
| #endif |
There was a problem hiding this comment.
I think this requires an #else clause for earlier versions of Visual Studio to use autoboost. Unless we're intentionally deprecating them in which case there should be an #error check.
yeswalrus
force-pushed
the
fix-vs2017-conformance
branch
from
0e78fcc to
1a74743
Compare
|
This looks good, but something strange is going on with Travis. Investigating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/permissive- would work as well