Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow building with newer standards than C++11 on non-MSVC platforms #1054

Merged
merged 1 commit into from
Mar 10, 2018
Merged

Allow building with newer standards than C++11 on non-MSVC platforms #1054

merged 1 commit into from
Mar 10, 2018

Conversation

gittyupagain
Copy link
Contributor

We were incorrectly including our own version of make_unique.h when building with C++14 or newer on non-MSVC platforms.

@gittyupagain gittyupagain requested a review from jdonald March 10, 2018 00:38
@jdonald jdonald added this to the v1.1.0 milestone Mar 10, 2018
@yeswalrus yeswalrus merged commit f1490f1 into master Mar 10, 2018
@yeswalrus yeswalrus deleted the fix-c++14-make_unique branch March 10, 2018 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdonald jdonald jdonald approved these changes

Assignees
No one assigned
Labels
bug compatibility
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gittyupagain @jdonald @yeswalrus