Refactor DispatchQueue to use an intrusive list instead of an std::list #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemercenary
force-pushed
the
ref-intrusivelinkage
branch
from
7da6e65 to
47c597f
Compare
An intrusive linked list, in this case, is a much better choice. Heap allocations for each entry in the collection are unavoidably necessary because entries have a variable size, which means a linked list is an improvement over `std::list`. If necessary, a next step could be to use a journal-based arena allocator in order to keep links in the list sequential with respect to each other.
codemercenary
force-pushed
the
ref-intrusivelinkage
branch
from
47c597f to
34be59a
Compare
| // Now abandon the queue, this should cause the async thread to quit: | ||
| ct->Abort(); | ||
| ASSERT_EQ(std::future_status::ready, f.wait_for(std::chrono::seconds(5))) << "Barrier did not abort fast enough"; | ||
| ASSERT_TRUE(*exception) << "Exception should have been thrown inside the Barrier call"; | ||
| ASSERT_FALSE(f.get()) << "Exception should have been thrown inside the Barrier call"; |
codemercenary
force-pushed
the
ref-intrusivelinkage
branch
from
c58dcc4 to
21a19e1
Compare
codemercenary
force-pushed
the
ref-intrusivelinkage
branch
from
21a19e1 to
cabbd11
Compare
codemercenary
force-pushed
the
ref-intrusivelinkage
branch
from
c2724d7 to
d4a6852
Compare
|
Added a test to make the failure @gtremper identified occur more reliably, then added another test and corrected said behavior. |
gtremper
added a commit
that referenced
this pull request
May 19, 2015
Refactor DispatchQueue to use an intrusive list instead of an std::list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An intrusive linked list, in this case, is a much better choice. Heap allocations for each entry in the collection are unavoidably necessary because entries have a variable size, which means a linked list is an improvement over
std::list.If necessary, a next step could be to use a journal-based arena allocator in order to keep links in the list sequential with respect to each other.