Eliminate race condition in ContextMapTest.VerifyWithThreads #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemercenary
force-pushed
the
fix-contextraces
branch
from
cb84963 to
bc380cb
Compare
This race condition occurs because we weren't waiting for the context to actually finish terminating before attempting to assess the state of the context map. This meant that the secondary thread was sometimes still running even when we expected it to have already terminated.
codemercenary
force-pushed
the
fix-contextraces
branch
from
bc380cb to
45428bf
Compare
|
+1 for adding better tests too. |
yeswalrus
added a commit
that referenced
this pull request
Jul 10, 2015
Eliminate race condition in ContextMapTest.VerifyWithThreads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This race condition occurs because we weren't waiting for the context to actually finish terminating before attempting to assess the state of the context map. This meant that the secondary thread was sometimes still running even when we expected it to have already terminated.