Fix static assert in CreationRules #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factory `New` methods presently are not being correctly evaluated for the inheritance rules that are required for factory `New` when the method has one or more arguments. Alter the static assert to be applied in all cases where static new is used.
| @@ -85,7 +85,7 @@ struct crh<construction_strategy::factory_new, T, Args...> | |||
| typedef T TActual; | |||
|
|
|||
| static_assert( | |||
| std::is_base_of<CoreObject, T>::value || !has_static_new<T>::value, | |||
| std::is_base_of<CoreObject, T>::value, | |||
| "If type T provides a static New method, then the constructed type MUST directly inherit Object" | |||
There was a problem hiding this comment.
This string "If type T provides a static New method..." matched the old static_assert, but if you make the above change, doesn't it become merely "The constructed type MUST directly inherit Object" ?
There was a problem hiding this comment.
No, because this whole template type--crh--is only instantiated in cases where T is being constructed via a factory new call.
jdonald
added a commit
that referenced
this pull request
Sep 17, 2015
Fix static assert in CreationRules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factory
Newmethods presently are not being correctly evaluated for the inheritance rules that are required for factoryNewwhen the method has one or more arguments. Alter the static assert to be applied in all cases where static new is used.