Implement SetThreadPriority #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gittyupagain implemented this functionality on a private branch awhile back, let's get it into mainline.
| default: | ||
| throw std::runtime_error("Attempted to assign an unrecognized thread priority"); | ||
| } | ||
| param.sched_priority = PTHREAD_MIN_PRIORITY + (percent*(PTHREAD_MAX_PRIORITY - PTHREAD_MIN_PRIORITY) + 50) / 100; |
There was a problem hiding this comment.
#include <sched.h>
int sched_get_priority_max(int policy);
int sched_get_priority_min(int policy);
should be used here.
hham
force-pushed
the
feature-threadpriority
branch
from
e399eea to
c480b3e
Compare
| #define PTHREAD_MIN_PRIORITY 0 | ||
| #endif | ||
| #if !defined(PTHREAD_MAX_PRIORITY) | ||
| #define PTHREAD_MAX_PRIORITY 31 |
There was a problem hiding this comment.
It looks like 63 is max priority in user space according to https://developer.apple.com/library/mac/documentation/Darwin/Conceptual/KernelProgramming/scheduler/scheduler.html.
Why did you put 31?
There was a problem hiding this comment.
This was done 20 months ago and never pushed. It was an initial attempt at the problem. Those numbers probably came from Linux documentation. It is unfortunate that it isn't defined. If 63 is correct, then that should be used instead.
There was a problem hiding this comment.
I'll make the change.
gittyupagain
pushed a commit
that referenced
this pull request
Oct 19, 2015
Implement SetThreadPriority
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gittyupagain implemented this functionality on a private branch awhile back, let's get it into mainline.
Fixes #784