Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VS2013 filesystem shim header problems #918

Merged
merged 2 commits into from
Apr 26, 2016
Merged

Conversation

codemercenary
Copy link
Contributor

Add a missing overload, fix missing return statement in filesystem shim header for VS2013

Add a missing overload, fix missing return statement in filesystem shim header for VS2013
@codemercenary codemercenary added this to the v1.0.0 milestone Apr 26, 2016
@@ -38,7 +41,7 @@ namespace std {
{}

basic_path& operator=(basic_path&& _Right) { *(awfsnamespace::wpath*)this = std::move(_Right); }
basic_path& operator=(const string_type& _Str) { *(awfsnamespace::wpath*)this = _Str; }
basic_path& operator=(const string_type& _Str) { return *(awfsnamespace::wpath*)this = _Str; }
basic_path& operator=(const wchar_t* _Ptr) { *(awfsnamespace::wpath*)this = _Ptr; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should those all have return?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crap. Yes they should.

@veronicaz41 veronicaz41 merged commit 32cb985 into master Apr 26, 2016
@veronicaz41 veronicaz41 deleted the fix-fsvs2013 branch April 26, 2016 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants