Fix double-decoration error #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -279,7 +279,9 @@ void AutoPacket::UpdateSatisfactionUnsafe(std::unique_lock<std::mutex> lk, const | |||
|
|
|||
| // Recursively mark unsatisfiable any single-output arguments on these subscribers: | |||
| std::vector<const AutoFilterArgument*> unsatOutputArgs; | |||
| auto MarkOutputsUnsat = [&unsatOutputArgs] (const SatCounter& satCounter) { | |||
| auto MarkOutputsUnsat = [&unsatOutputArgs] (SatCounter satCounter) { | |||
| @@ -34,7 +34,7 @@ struct SatCounter: | |||
| /// </summary> | |||
| /// <returns>True if this decrement yielded satisfaction of all arguments</returns> | |||
| bool Decrement(void) { | |||
| return !--remaining; | |||
| return remaining && !--remaining; | |||
There was a problem hiding this comment.
Nice, I like compact logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is if an auto filter has multiple inputs marked as unsatisfiable, each time it is marked as unsatisfiable, we call
IncProducerCount, so the auto filter will become complete prematurely.The fix is to make sure
IncProducerCountonly got called once for each auto filter, only when all its inputs are satisfied or marked as unsatisfiable.