Fix NotifyWhenAutowired not working with some types #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Autowired<ForwardDeclared> decl; | ||
| decl.NotifyWhenAutowired([]() {std::cout << "thing"; }); | ||
| } | ||
| */ |
There was a problem hiding this comment.
No - I'm not sure how we want to handle the documentation of compile time failures? I'd like to leave it in
There was a problem hiding this comment.
Oh, I missed the part where you commented about what the failure should be.
I've thought about this, I experimented with CMake's try_compile feature, but decided against using that for things that aren't build environment provisioning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to work correctly the type must first be registered using auto_id_t. By adding the registration in the call to NotifyWhenAutowired, this problem is prevented at the expense of disallowing calls to NotifyWhenAutowired on forward declared types