Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining depend/package issues; Misc updates #237

Merged
merged 4 commits into from
Dec 11, 2019
Merged

Fix remaining depend/package issues; Misc updates #237

merged 4 commits into from
Dec 11, 2019

Conversation

RecursiveCptHook
Copy link
Contributor

  • Fixes remaining security issues as per npm audit (result of old phantomjs)
  • Removed usage of phantomjs due to deprecation/archival (mocha-phantomjs info)
  • Migrated from mocha-phantomjs to mocha-chrome
  • Added ultraleap to the bower keywords
  • Updated changelog
  • Removed erroneous change from other PR that was under test in compiled leapjs

@RecursiveCptHook
Copy link
Contributor Author

Awesome, and Travis is functioning as expected now also. 👍

jselstad
jselstad approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@jselstad jselstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let's see if Github is going to come back with a Round 2 on the audits...

@jselstad jselstad merged commit 3d95321 into master Dec 11, 2019
@jselstad jselstad deleted the fix-migrate-phantomjs branch December 11, 2019 01:32
@RecursiveCptHook RecursiveCptHook mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jselstad jselstad jselstad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RecursiveCptHook @jselstad