Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Replace & improve terminal emulator #409

Merged
merged 30 commits into from
May 5, 2017
Merged

Replace & improve terminal emulator #409

merged 30 commits into from
May 5, 2017

Conversation

notnotdrew
Copy link
Member

@notnotdrew notnotdrew commented Feb 17, 2017 •
edited
Loading

Addressed in 937767a:

Todo

Outstanding:

  • On Windows, resizing the terminal font can break the emulator's fit
  • On Windows, popout terminal resizing of font or window can break the emulator's fit

Parity:

  • terminal pop out/in (addressed in 7132081)
  • handle openPath & openLab (addressed in 1c4b3bd)
  • copy/paste (addressed in 122b524)
    • keymaps
    • Edit menu (Edit > Copy/Paste)
    • terminal context menu
  • keymap to toggle terminal focus (addressed in f3060d2)
  • while terminal is focused, keymaps to increase/decrease/reset font size (addressed in 8f7affb)
  • persistent terminal font size (if changed, changes persist after restarting app) (addressed in 0705321)
  • configurable terminal background & font colors (addressed in b90bb73 & d6f1f3b)

New stuff:

@notnotdrew notnotdrew changed the title Replace term.js with xterm.js Replace & improve terminal emulator Feb 17, 2017
@notnotdrew notnotdrew self-assigned this Feb 22, 2017
@mobesa
Copy link

mobesa commented Feb 23, 2017 •
edited
Loading

@drewprice how do you pop out the terminal in the IDE? Also, how do you manage to scroll ('cause I can't)?
Learn IDE v2.4.0 on Ubuntu 16.04.

@notnotdrew
Copy link
Member Author

notnotdrew commented Feb 27, 2017 •
edited
Loading

@mobesa check out the Learn IDE's help center

notnotdrew added 18 commits March 24, 2017 14:57
@notnotdrew
Handle keymaps for terminal font resizing
8f7affb
@notnotdrew
Catch and parse ctrl characters on win and linux
476601c
@notnotdrew
Remove learn-term.js and add xterm
0f298e4
@notnotdrew
Add fully configurable color scheme
b90bb73
@notnotdrew
Add inline CSS when writing a new stylesheet fails
d6f1f3b
@notnotdrew
Convert legacy config keys to new color config scheme
eafaea7
@notnotdrew
Add custom color configuration by JSON scheme
b8bcbca
@notnotdrew
Improve readability of color configuration
7bca3b8
@notnotdrew
Export event-bus after running initialization
db23667
@notnotdrew
Introduce working popout-terminal alternative
7132081
@notnotdrew
Remove legacy popout terminal
384f2e6
@notnotdrew
Rename popout-terminal to popout-emulator
06d37a2
@notnotdrew
Move popout-emulator script to seperate file
fd73df2
@notnotdrew
Include custom terminal colors in popout emulator
6eddb86
@notnotdrew
Rewrite colors module using babel as compiler
2daacb6
@notnotdrew
Use babel to compile the terminal view
af34b25
@notnotdrew
Fit emulator when popout is resized
a69c7c0
@notnotdrew
Handle keyboard shortcuts in popout emulator
585ac19
@notnotdrew notnotdrew mentioned this pull request Mar 30, 2017
Merged
This was referenced Mar 30, 2017
Closed
Closed
Closed
@notnotdrew
Copy link
Member Author

notnotdrew commented Apr 24, 2017 •
edited
Loading

Pending a QA pass, I think we will go ahead and merge as is. Windows touchup can go out in a patch.

@notnotdrew notnotdrew merged commit 2388df1 into master May 5, 2017
@notnotdrew notnotdrew deleted the terminal branch May 5, 2017 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mobesa mobesa mobesa approved these changes

Assignees

@notnotdrew notnotdrew

Labels
blocker terminal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notnotdrew @mobesa