Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DHT ignore SIGINT #493

Merged
merged 5 commits into from
Jul 4, 2022
Merged

Make DHT ignore SIGINT #493

merged 5 commits into from
Jul 4, 2022

Conversation

dbaranchuk
Copy link
Collaborator

@dbaranchuk dbaranchuk commented Jul 4, 2022

If someone uses hivemind from the Python interactive console/Jupyter notebooks, the keyboard interrupts (Ctrl+C) are propagated to children processes including the DHT process and the DHT gets killed. This PR fixes this behavior, so the DHT continues to run in background.

See also: learning-at-home/go-libp2p-daemon#19

@dbaranchuk dbaranchuk requested a review from borzunov July 4, 2022 14:47
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #493 (b08b4d4) into master (ee75b91) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #493   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files          80       80           
  Lines        7812     7814    +2     
=======================================
+ Hits         6688     6690    +2     
  Misses       1124     1124           
Impacted Files Coverage Δ
hivemind/dht/dht.py 90.41% <100.00%> (+0.11%) ⬆️
hivemind/averaging/matchmaking.py 87.79% <0.00%> (-1.20%) ⬇️
hivemind/averaging/averager.py 88.24% <0.00%> (+0.23%) ⬆️
hivemind/dht/node.py 91.44% <0.00%> (+0.71%) ⬆️

@dbaranchuk dbaranchuk merged commit 61e5e8c into master Jul 4, 2022
@dbaranchuk dbaranchuk deleted the sigint branch July 4, 2022 16:57
mryab pushed a commit that referenced this pull request Sep 13, 2022
* make DHT ignore SIGINT
* update p2pd version

Co-authored-by: @borzunov
(cherry picked from commit 61e5e8c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants