Support Python 3.11 #574
Merged
Support Python 3.11 #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
==========================================
- Coverage 85.26% 85.23% -0.04%
==========================================
Files 81 81
Lines 8004 8006 +2
==========================================
- Hits 6825 6824 -1
- Misses 1179 1182 +3
|
requirements.txt
Outdated
| @@ -7,7 +7,7 @@ msgpack>=0.5.6 | |||
| sortedcontainers | |||
| uvloop>=0.14.0 | |||
| grpcio-tools>=1.33.2 | |||
| protobuf>=3.12.2,<4.0.0 | |||
| protobuf==4.23.4 | |||
There was a problem hiding this comment.
Fixing protobuf version to latest can cause potential conflicts with some older projects. We gotta figure out some reasonably old version where the code (still) works.
|
@borzunov i've added some tweaks to make py311 install properly. please take a look when u have time |
borzunov
commented
Jul 20, 2023
borzunov
commented
Jul 20, 2023
Co-authored-by: Alexander Borzunov <borzunov.alexander@gmail.com>
Co-authored-by: Alexander Borzunov <borzunov.alexander@gmail.com>
justheuristic
force-pushed
the
python-3-11
branch
from
fe01882 to
b769f89
Compare
|
tested: petals client v2.0.0.post3 works in colab with this version of hivemind and forced protobuf 4.x |
mryab
pushed a commit
that referenced
this pull request
Jul 23, 2023
(cherry picked from commit ec1d7fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.11 (stable) has been released in Oct 2022 (https://www.python.org/downloads/release/python-3110/) and soon may become a standard version across many distros. We need to support it.