[minor] allow overriding args/kwargs behavior in Runtime #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mryab
reviewed
Aug 25, 2023
hivemind/moe/server/runtime.py
Outdated
Comment on lines
109
to
110
| if self.stats_report_interval is not None: | ||
| self.stats_reporter.report_stats(pool.name, batch_size, batch_processing_time) |
There was a problem hiding this comment.
I think it might lead to unintended "0 batches processed" log entries if the user overrides this without carefully considering the original function. Best to leave only the batch size computation inside the function and keep all the logging/time measuring logic outside the function
There was a problem hiding this comment.
good catch, fixed it now, please take another look
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
==========================================
+ Coverage 85.38% 85.42% +0.04%
==========================================
Files 81 81
Lines 8006 8009 +3
==========================================
+ Hits 6836 6842 +6
+ Misses 1170 1167 -3
|
mryab
approved these changes
Aug 25, 2023
borzunov
approved these changes
Aug 25, 2023
borzunov
reviewed
Aug 25, 2023
| @@ -108,6 +105,11 @@ def run(self): | |||
| if not self.shutdown_trigger.is_set(): | |||
| self.shutdown() | |||
|
|
|||
| def process_batch(self, pool: TaskPoolBase, batch_index: int, *batch: torch.Tensor) -> Tuple[Any, int]: | |||
There was a problem hiding this comment.
batch_index is not used, is it okay?
There was a problem hiding this comment.
yep, it is meant to be exposed for subclassing
mryab
pushed a commit
that referenced
this pull request
Aug 31, 2023
* allow overriding args/kwargs in Runtime * switch stats time to time.perf_counter --------- Co-authored-by: Your Name <you@example.com> Co-authored-by: Max Ryabinin <mryabinin0@gmail.com> (cherry picked from commit 33a9a41)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts a part of runtime that is responsible for calling pool's process func.
This is to allow developer to extend this behavior in
petalsdownstream applications without having to rewrite the whole runtime.run method.