Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more multiprogram statistics queries #3204

Merged
merged 13 commits into from
Feb 19, 2021
Merged

Add more multiprogram statistics queries #3204

merged 13 commits into from
Feb 19, 2021

Conversation

willgearty
Copy link
Member

This adds new queries to the /manage/statistics page to get multiprogram stats on teacher registration (# of teachers), class registration (# of classes), and student registration (# of students). Since these stats are basically already calculated for a single program for the big board modules, The results are shown in a neat table and in a graph (see screenshots below). I just made those static functions and call them for each of the selected programs. While I was at it, I made the form prettier, table-fied most of the outputs of the other queries, and fixed a minor bug on the student big board (#3202).

image
image
image

Fixes #2922 and fixes #3202

@lgtm-com

This comment has been minimized.

@kkbrum
Copy link
Contributor

kkbrum commented Feb 12, 2021

I think this is all really cool! I am getting inconsistent results between the generated tables and my individual dashboards though. Could you check whether the table numbers are matching up with the dashboard for one of your programs?

Class registration:

  • number of approved classes is too low (perhaps this is counting scheduled classes?)
  • number of class-student hours (both registered and approved) is too high

Teachers:

  • number of teachers with approved classes is too low (perhaps counting scheduled classes?)

Additionally, perhaps this is what's being counted, but I think having the second column type be scheduled numbers instead of approved numbers makes sense. Nearly all classes get approved, many fewer get scheduled, and that's what actually drives capacity and such so is arguably the most important.

FInally, I dont understand what the meaning of the "__ matched by query" line is, so could we either remove that or make it more meaningful?

@willgearty
Copy link
Member Author

OK, I think I've fixed the discrepancies between the stats here and the teacher big board. Can you check and see if those problems are resolved for you, @kkbrum? Then I can go in and make the other changes you requested.

@lgtm-com

This comment has been minimized.

@willgearty
Copy link
Member Author

willgearty commented Feb 18, 2021

OK, I've added scheduled classes, etc. to the output for the teacher and classes queries. I also cleaned up the templates to make the query number a little clearer to the user. Let me know what you think @kkbrum!

(LGTM alerts seem fine to ignore to me)

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

Copy link
Contributor

@kkbrum kkbrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Doesn't quite match the dashboard, but that's a problem with the dashboard that I'll make an issue for. This looks great!

@willgearty willgearty merged commit 28ce571 into main Feb 19, 2021
@willgearty willgearty deleted the stats-form branch February 19, 2021 01:52
willgearty added a commit that referenced this pull request Feb 26, 2021
willgearty added a commit that referenced this pull request May 27, 2021
* Initial docs for stable release 13

* Docs for #3116, #3117, and #3118

* Added docs about django upgrade

* Docs for #3128

* Docs for #3129, #3133, #3134, and #3137

* Docs for #3156 and #3153

* Docs for #3174, #3163, and #3184

* Docs for #3139, #3140, and #3141

* Docs for #3143, #3150, #3154, #3160, #3162, and #3168

* Docs for #3171, #3185, #3186, and #3188

* Docs for #3131 and #3189

* Docs for #3149 and #3190

* Docs for #3193, #3194, #3195, #196, and #3197

* Clarification

* Docs for #3192, #3201, #3209, and #2248

* Docs for #3204, #3212, #3214, #3205, 9fd073c, and #3226

* Docs for #3232, de5861c, #3231, #3233, #3234, #3237, #3238, and #3239

* Fix indent

* Docs for #3227 and #3235

* Add missing word

* spelling

* Docs for e57581f, #3255, #3253, #3257, and #3249

* Docs for #3254, #3260, and #3262

* Docs for #3263, #3272, #3240, #3264, #3266, and #3270

* clarifications

* Docs for #3283 and #3252

* Docs for #3288 and misc commits

* Docs for #3292, #3311, #3286, #3289, and #3279

* Docs for a377f0d; move note

* Docs for #3315, #3290, and #3322

* Docs for #3273 and #3317

* Final edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

student big board check-in stat is wrong Feature Request: Multiprogram Stats
2 participants