-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make fruitsalad juicier. #3704
base: main
Are you sure you want to change the base?
Make fruitsalad juicier. #3704
Conversation
1. Add a small hover effect to the left-side tabs. While we're at it, fix the accent stripe size to accommodate custom rounding_radius. (No sites currently seem to customize it but maybe this'll make it easier.) 2. Additionally, enable audio feedback if the user types in one of a few famous cheat codes. Prior art: https://www.janneysound.com/project/soundstair-musical-stairs/ at the Boston Museum of Science, among other places. Thanks also to Amy Woodruff of Splash!Chicago for a long-ago suggestion. Further reading: https://garden.bradwoods.io/notes/design/juice
Thanks @pteromys! I like the bounce effect a lot (and it's great that you incorporated the rounding-radius). While cute, I don't think the piano sound effects are necessary. I'd argue that they should be more of a template override kind of thing. |
Heh, sure, the piano sound effects are merely an Easter egg. Depending on what you think we should support, we could do either of:
|
Actually, now that I think about it, we're trying to move away from encouraging chapters to make template overrides, since they are a pain to maintain for us (during stable releases) and for them (when admin teams turnover). So, if you really want to encourage/include the functionality, it might be nice to set it up as something that can be enabled/disabled with a global boolean tag (the default would be disabled)? Let me know if you have any questions about how to implement something like that. |
@pteromys just poking you to see if you are still working on this? |
Interested, but no bandwidth for at least two months. Check back in July, if you can stand to let it sit that long? |
@pteromys, any chance you've got time to finish this up? |
piano.mp4
Add a small hover effect to the left-side tabs. While we're at it, fix the accent stripe size to accommodate custom rounding_radius. (No sites currently seem to customize it but maybe this'll make it easier.)
Additionally, enable audio feedback if the user types in one of a few famous cheat codes.
Prior art: https://www.janneysound.com/project/soundstair-musical-stairs/ at the Boston Museum of Science, among other places. Thanks also to Amy Woodruff of Splash!Chicago for a long-ago suggestion.
Further reading: https://garden.bradwoods.io/notes/design/juice