Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade order imports hook and fix linting. #101

Merged
merged 1 commit into from
Mar 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ repos:
- id: end-of-file-fixer
exclude: '^.+?(\.json|\.po)$'
- repo: https://github.com/asottile/reorder_python_imports
rev: v1.3.3
rev: v2.7.1
hooks:
- id: reorder-python-imports
language_version: python3.9
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ To export the necessary p12 certificate used for codesigning, first be sure to h

Then, be sure that the certificate is valid (selecting it will show a checkmark and say that it is valid), and that it has an associated private key. You can check if there is a private key in keychain access. Next to the name on the left, there should be a toggle, which would open to show that there is a private key, associated with your name. This is the bundle that is able to be exported. Using a certificate without this associated private key will NOT work.

Once you have confirmed that the private key is linked with the certificate, right click, Export, and then select p12 as the file option. If there is no p12 as an option, your certificate does not have the private key.
Once you have confirmed that the private key is linked with the certificate, right click, Export, and then select p12 as the file option. If there is no p12 as an option, your certificate does not have the private key.

Choose a password that will be associate with the certificate, and enter when prompted (also, write it down because you will not access it again). Add the password and the file in 1Password for team access.

Expand Down
3 changes: 1 addition & 2 deletions src/kolibri_app/__init__.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import os

from kolibri_app.constants import MAC

from kolibri.main import enable_plugin
from kolibri_app.constants import MAC

__version__ = "0.3.0"

Expand Down
9 changes: 4 additions & 5 deletions src/kolibri_app/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,15 @@
from threading import Thread

import wx
from kolibri_app.constants import APP_NAME
from kolibri_app.logger import logging
from kolibri_app.view import KolibriView
from magicbus.plugins import SimplePlugin

from kolibri.main import initialize
from kolibri.plugins.app.utils import interface
from kolibri.plugins.app.utils import SHARE_FILE
from kolibri.utils.conf import KOLIBRI_HOME
from kolibri.utils.server import KolibriProcessBus
from kolibri_app.constants import APP_NAME
from kolibri_app.logger import logging
from kolibri_app.view import KolibriView
from magicbus.plugins import SimplePlugin


share_file = None
Expand Down