-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copyToClipboard, home, (un)publishedResource icons, generate RST replacements #217
Add copyToClipboard, home, (un)publishedResource icons, generate RST replacements #217
Conversation
@nucleogenesis this resolves the outlined If that is what is addressed with this PR, I'm happy to approve 🙂 |
All icons are finally in! 💯 What I don't see are the required colors, primary for the If that is all going to fall in place once this PR is merged, then all's good! One last thing that might need a retouch are the aliases. Technically, in Studio UI both That's why my suggestion from #141 was to use the following aliases:
|
82aa269
to
3a7fc57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 🌟s for improving the contrast of that color! 🙏🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review! 👍 for the copyToClipboard
alias and the suggested ones for the filled/outlined dots
Description
Currently, there is no
copy
icon with theOutline
style in KDS - which is necessary in Studio.In Studio, however, we have not fully applied
KIcon
andKIconButton
and so forth - so there are many icons used there by way of Vuetify's handling of material icons.But - @radinamatic needs these icons on hand so she can update documentation with access to all of the icons we see in our products, even if the product isn't currently getting the icon from KDS.
Thus I've added it here.
Issue addressed
Fixes #141
Also - the
unpublishedChanges
andpublishedResource
icons aretokens.success
.Initially, the closest color we had was
brand.secondary
which is alsotokens.focusOutline
- this matched the similar version from Vuetify currently used in Studio.That did not pass muster as an icon for a11y purposes - so I've opted to use that darker green
tokens.success
color which passes in the icon context:Steps to test
copyToClipboard
icon is there and is acceptable.@jtamiace - do you agree that
copyToClipboard
is a solid alias for that icon? It matches the actual use of it in Studio anyway. See @indirectlylit 's comment from #141@radinamatic does this solve the concerns you had in #141?