Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KListWithOverflow: Miscellaneous fixes #612

Merged

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Apr 9, 2024

Description

Two fixes of the KListWithOverflow component:

  • Add scoped style, to avoid interfering with other styles such as those of the LanguageSwitcherList.
  • Add position: absolute to hidden elements to prevent them from taking up space on the screen.
    • before:
      image
    • after:
      image

Changelog

  • #612

    • Description: Prevent KListWithOverflow hidden elements from taking up space on the screen.
    • Products impact: bugfix.
    • Addresses: - .
    • Components: KListWithOverflow.
    • Breaking: no.
    • Impacts a11y: no.
    • Guidance: - .
  • #612

    • Description: Scope the styles of the KListWithOverflow component.
    • Products impact: bugfix.
    • Addresses: - .
    • Components: KListWithOverflow.
    • Breaking: no.
    • Impacts a11y: no.
    • Guidance: - .

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlexVelezLl, changes make sense to me. I just requested one changelog update. After that, feel free to merge.

@MisRob MisRob self-assigned this Apr 10, 2024
@AlexVelezLl
Copy link
Member Author

Thanks @MisRob! I had an internal conflict about how specific the changelog had to be 😅. Just updated it 👐.

@AlexVelezLl AlexVelezLl merged commit 4161e6a into learningequality:release-v3 Apr 10, 2024
8 checks passed
@AlexVelezLl AlexVelezLl deleted the fix-klistwithoverflow branch April 10, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants