Skip to content

Commit

Permalink
Revert "Update release workflow to properly self-reference."
Browse files Browse the repository at this point in the history
This reverts commit 25f5b5f.
  • Loading branch information
rtibbles committed Mar 21, 2024
1 parent 3716bcf commit 109c37c
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 8 deletions.
13 changes: 9 additions & 4 deletions .github/workflows/build_apk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ on:
tar-url:
required: false
type: string
ref:
description: 'A ref for this workflow to check out its own repo'
required: false
type: string
signed:
description: 'Should this be signed with the development key? (mutually exclusive with release)'
required: false
Expand Down Expand Up @@ -71,8 +75,6 @@ jobs:
runs-on: ubuntu-latest
env:
SERVICE_ACCOUNT_JSON: '${{ secrets.KOLIBRI_ANDROID_PLAY_STORE_API_SERVICE_ACCOUNT_JSON }}'
REPOSITORY: ${{ github.action_repository }}
REF: ${{ github.action_ref }}
outputs:
apk-file-name: ${{ steps.get-apk-filename.outputs.apk-file-name }}
version-code: ${{ steps.get-version-code.outputs.version-code}}
Expand All @@ -88,9 +90,12 @@ jobs:
echo "Must specify only one reference for the tar file to build the APK with."
exit 1
- uses: actions/checkout@v4
if: ${{ !inputs.ref }}
- uses: actions/checkout@v4
if: ${{ inputs.ref }}
with:
repository: ${{ env.REPOSITORY }}
ref: ${{ env.REF }}
repository: learningequality/kolibri-installer-android
ref: ${{ inputs.ref }}
- name: Get SHA of current commit
id: get-commit
# Note that we do this, so that we get the same commit regardless
Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/release_apk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ on:
description: 'The version code to promote to the open testing track'
required: true
type: string
ref:
description: 'A ref for this workflow to check out its own repo'
required: true
type: string
secrets:
KOLIBRI_ANDROID_PLAY_STORE_API_SERVICE_ACCOUNT_JSON:
required: false
Expand All @@ -23,13 +27,14 @@ jobs:
runs-on: ubuntu-latest
env:
SERVICE_ACCOUNT_JSON: '${{ secrets.KOLIBRI_ANDROID_PLAY_STORE_API_SERVICE_ACCOUNT_JSON }}'
REPOSITORY: ${{ github.action_repository }}
REF: ${{ github.action_ref }}
steps:
- uses: actions/checkout@v4
if: ${{ !inputs.ref }}
- uses: actions/checkout@v4
if: ${{ inputs.ref }}
with:
repository: ${{ env.REPOSITORY }}
ref: ${{ env.REF }}
repository: learningequality/kolibri-android-installer
ref: ${{ inputs.ref }}
- name: Set up Python 3.9
uses: actions/setup-python@v5
with:
Expand Down

0 comments on commit 109c37c

Please sign in to comment.