Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When replacing questions, the replacements should be placed in the positions of the questions which were selected to be replaced. #12134

Closed
Tracked by #12037
nucleogenesis opened this issue May 6, 2024 · 0 comments · Fixed by #12218
Assignees
Labels
DEV: frontend P1 - important Priority: High impact on UX

Comments

@nucleogenesis
Copy link
Member

nucleogenesis commented May 6, 2024

Overview

During question replacement in quiz creation, the replacements are being slotted to the bottom of the list rather than put into the place of the questions which were selected to be replaced.

This handleReplacement function should be refactored so that the position of the questions to be removed are replaced with the user's selected replacements.

This function currently just gathers a list of the questions which are not being replaced. Then it just pops the new questions on the end. I think that updating the filter to a map where we either return the first replacement or the "activeQuestion" we're getting in the iteration. I think an approach like this can avoid getting complicated but don't feel committed to this if it doesn't pan out.

Note how the questions I selected for replacement are at the bottom rather than where I'd selected the questions I wanted replaced

2024-05-06.16-57-59.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P1 - important Priority: High impact on UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants