Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ContentCardList to use the new KCardGrid and the AccessibleResourceCard and AccessibleFolderCard #12732

Open
4 tasks
Tracked by #11888
marcellamaki opened this issue Oct 22, 2024 · 1 comment · May be fixed by #13060
Open
4 tasks
Tracked by #11888
Assignees
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend P1 - important Priority: High impact on UX TAG: a11y Affecting accessibility

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Oct 22, 2024

Overview

In the course of the work on #13008 and #12895, the refactoring of the content cards to use the new AccessibleResourceCard and AccessibleFolderCard was out of scope. However, to benefit from the accessibility improvements of the KCard in the new feature, we want to refactor the grid to use these new cards.

Requirements

This issue focuses both on the actual refactor but also in-scope is meticulous alignment to the figma specs if further refinements are needed. Now that we have a fully integrated side panel where we can use real data (content nodes) to stress test the content cards in a variety of screen resolutions and content types, we need to make sure the cards are pixel perfect and bug free, in addition to just swapping them out.

  • REFACTOR: Use the AccessibleFolderCard and AccessibleResourceCard within the side panel for topic tree and search results navigation
  • ADD: Card metadata is integrated and displayed according to the figma, using the composable created by Allan in Helper function(s) to manage display of metadata tags in the new cards #12686
  • CONFIRM: Cards are properly responsive across the side panel display (on large screens) and compress properly on mobile screen resolutions
  • CONFIRM: Cards are fully to spec. Jessica should be added as a reviewer on the PR and give a 👍
@marcellamaki
Copy link
Member Author

marcellamaki commented Feb 3, 2025

Managed in the course of other work It was not :)

@marcellamaki marcellamaki reopened this Feb 3, 2025
@marcellamaki marcellamaki added P1 - important Priority: High impact on UX TAG: a11y Affecting accessibility APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Feb 4, 2025
@nucleogenesis nucleogenesis self-assigned this Feb 5, 2025
@nucleogenesis nucleogenesis linked a pull request Feb 8, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend P1 - important Priority: High impact on UX TAG: a11y Affecting accessibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants