-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Accessible Cards in Lesson Resource Selection #13060
base: develop
Are you sure you want to change the base?
Use Accessible Cards in Lesson Resource Selection #13060
Conversation
Build Artifacts
|
48e8913
to
ffb7871
Compare
The Bookmarks count is not updated on the root page of the LessonResourceSelection when I add/remove bookmarks while navigating the tree. So if I have 4 bookmarks, go in and add 4 more, then I go back to the root and see the bookmarks card still has 4. I tried to hack at it to fix it a bit but couldn't get it to re-fetch correctly. I gave it like 30 mins and gave up on it - should I make a follow-up for issue for this? FWIW I tried:
It seems like it might be some part of how the |
Hey @nucleogenesis! Yes, we will need to call the
The reason of the infinite page reload here is because fetching bookmarks triggers this loading computed property to true, and this causes a remount of the router view here. And thats why if we call it inside the setup method it will cause an infinite loop of loading -> fetching -> loading -> fetching, etc. A solution for this could be to replace this I think this can be a follow up issue, and we can explore more there the implications of each option :) |
}); | ||
} | ||
|
||
function isBookmarked(contentnode_id) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wonder if it would be better to check the existence of content.bookmark
object to verify if the resource has been bookmarked? For example we use this to show the "bookmarked x days ago" in the SelectFromBookmarks subpage here.
With this we avoid needing to load all bookmarks each time this component is mounted. Because this component will be remounted each time we navigate through the folder tree/bookmarks/search results and I think we can save us from making this fetch all these times.
@toggleBookmark="toggleBookmark" | ||
> | ||
<template #belowTitle> | ||
<p v-if="contentCardMessage(content)">{{ contentCardMessage(content) }}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
01fd448
to
7c136c3
Compare
7c136c3
to
c92f603
Compare
d72366c
to
00e1d50
Compare
Summary
Screencast_20250207_133314.webm
TODO
References
Closes #12732
Reviewer guidance
TBD