Enhanced Quizzes: Initial frontend state management API #11088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
Build Artifacts
|
nucleogenesis
force-pushed
the
feature--enhanced-quizzes--11012-initial-state-management
branch
from
fe9769f to
720f381
Compare
This was referenced Aug 18, 2023
AllanOXDi
reviewed
Aug 22, 2023
There was a problem hiding this comment.
@nucleogenesis, the code looks good to me, and it is well-written and easy to understand.
| * @throws {Error} if section not found | ||
| * Deletes the given section by section_id */ | ||
| function removeSection(section_id) { | ||
| const updatedSections = get(allSections).filter(section => section.section_id !== section_id); |
| { section_id: get(activeSection).section_id, question_count: newQuestionCount } | ||
| ); | ||
| updateSection({ | ||
| section_id: get(activeSection).section_id, |
There was a problem hiding this comment.
None blocking comment: you could use a more descriptive name for the variable section it is a bit too generic. It could be more descriptive if it were named something like currentSection or something along that line. I believe this would keep changing too.
nucleogenesis
force-pushed
the
feature--enhanced-quizzes--11012-initial-state-management
branch
from
7472f7b to
19038b1
Compare
AllanOXDi
approved these changes
Aug 25, 2023
nucleogenesis
force-pushed
the
feature--enhanced-quizzes--11012-initial-state-management
branch
from
19038b1 to
3ab9f01
Compare
nucleogenesis
deleted the
feature--enhanced-quizzes--11012-initial-state-management
branch
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sets up foundation for state management. This introduces some "types" which can be validated much like Vue's prop validators. This is here to hopefully make clear what kinds of data we're dealing with, what functions expect to take and return, etc.
The root of this is in a new composition API module
useQuizCreationwhich will be the source of truth for state -- which will be initialized in the quiz creation root component. The state objects and functions can then be passed around and called to wherever that root component wants.In general, there are utilities here purpose-built for the quiz creation workflow. We can:
Follow up issues will hopefully be able to make use of this straight away and extend it with relative ease.
References
Closes #11012
Reviewer guidance
Testing checklist
PR process