Select resource sidepanel #11511
Closed
Select resource sidepanel #11511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
Ran into some issues w/ the way the overflow calculation was done as I tried to adjust the heights of the tabs and their containers themselves This ultimately ends up losing some items which were impacting the calculations which will be fixed in a subsequent commit
KDS commit 047379f579ad7067381a9576edc21abd12ad8378 is a req for this change
AllanOXDi
force-pushed
the
select-resource-sidepanel
branch
from
891a532 to
2043d71
Compare
1 task
AllanOXDi
force-pushed
the
select-resource-sidepanel
branch
from
8819943 to
b14457f
Compare
AllanOXDi
force-pushed
the
select-resource-sidepanel
branch
from
776ba5c to
b14457f
Compare
8 tasks
rtibbles
reviewed
Dec 7, 2023
|
|
||
| function fetchTopicResource(topicId) { | ||
| const topicNodePromise = ContentNodeResource.fetchModel({ id: topicId }); | ||
| const childNodesPromise = ContentNodeResource.fetchCollection({ |
There was a problem hiding this comment.
As per our conversation - this is where we could use the new fetchTree method instead, to fetch both the topic and its children in one go.
To limit data, can pass the depth: 1 getParam to only get the immediate descendants. The only thing to be aware of here is that the return data here is that the children are paginated by default.
Can see an example of it in use here:
|
@AllanOXDi I think that we'll do best to make a new PR w/ the work you and I have done separately from this which will be based on the latest develop. I'll close this PR for now but retain the branch so we have it as reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
…
References
…
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarnandpip)