Quiz rebase regression fixes #11661
Merged
Quiz rebase regression fixes #11661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
nucleogenesis
commented
Dec 19, 2023
Comment on lines
+110
to
+131
| <KGrid v-if="!activeQuestions.length" class="questions-list-label-row"> | ||
| <KGridItem | ||
| class="right-side-heading" | ||
| style="padding: 0.7em 0.75em;" | ||
| > | ||
| <KButton | ||
| primary | ||
| :text="coreString('optionsLabel')" | ||
| > | ||
| <KButton | ||
| primary | ||
| :text="coreString('optionsLabel')" | ||
| > | ||
| <template #menu> | ||
| <KDropdownMenu | ||
| :primary="false" | ||
| :disabled="false" | ||
| :hasIcons="true" | ||
| :options="activeSectionActions" | ||
| @tab="e => (e.preventDefault() || $refs.selectAllCheckbox.focus())" | ||
| @select="handleActiveSectionAction" | ||
| /> | ||
| </template> | ||
| </KButton> | ||
| </KGridItem> | ||
| </KGrid> | ||
| <template #menu> | ||
| <KDropdownMenu | ||
| :primary="false" | ||
| :disabled="false" | ||
| :hasIcons="true" | ||
| :options="activeSectionActions" | ||
| @tab="e => (e.preventDefault() || $refs.selectAllCheckbox.focus())" | ||
| @select="handleActiveSectionAction" | ||
| /> | ||
| </template> | ||
| </KButton> | ||
| </KGridItem> | ||
| </KGrid> |
There was a problem hiding this comment.
Note: I moved this outside of the div in order to put the styles below onto that div without affecting this [Options] dropdown menu. Then I put the same v-if condition on it as the same [Options] button is displayed a little differently below.
nucleogenesis
commented
Dec 19, 2023
| <!-- TODO This should be a separate component like "empty section container" or something --> | ||
| <div | ||
| v-if="!activeQuestions.length" | ||
| style="text-align: center; padding: 0 0 1em 0; max-width: 350px; margin: 0 auto;" |
There was a problem hiding this comment.
max-width: 350px here is to accommodate the styles represented in the Figma so that the text remains at a readable length across languages as the same text in other languages may take up much more horizontal space
Build Artifacts
|
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "SectionEditor" side panel not displaying
Some issues w/ .value removal seem to have been the culprit here. I've also reworked some of the local state management for the form.
Fixes section tab styles
Artifact of mistaken conflict resolution.
Re-applies styles from @AllanOXDi 's previous work styling the "No questions" view
Another artifact of mistakes in conflict resolution / rebasing.
Reviewer guidance
QA @radinamatic
NOTE: The alternative "when questions are present" is not necessary to be tested here for two reasons: 1) there is no way to add questions w/out altering the code and 2) it has been tested locally and works as it did previously so it can wait for more robust testing
Code Review
Does everything make sense?
Testing checklist
PR process
Reviewer checklist
yarnandpip)