Update ExamSerializers according to v3 model #11674
Conversation
github-actions
bot
added
DEV: backend
| self.assertEqual(response.status_code, 400) | ||
| self.assertFalse(models.Exam.objects.filter(title=title).exists()) | ||
|
|
||
| def test_quiz_section_with_no_resource_pool(self): |
There was a problem hiding this comment.
Was curious about the resource pool and if it's required!
| @@ -195,8 +200,8 @@ export default function useQuizCreation(DEBUG = false) { | |||
| * @affects _channels - Calls _fetchChannels to bootstrap the list of needed channels | |||
| * Adds a new section to the quiz and sets the activeSectionID to it, preparing the module for | |||
| * use */ | |||
| function initializeQuiz() { | |||
| set(_quiz, objectWithDefaults({}, Quiz)); | |||
| function initializeQuiz(collection) { | |||
There was a problem hiding this comment.
Could you add a @param {string} collection - The collection (aka current class ID) to associate the exam with to the doc string above here?
ozer550
force-pushed
the
update-ExamSerializer-for-question_sources
branch
from
123b1d0 to
cb88abc
Compare
Build Artifacts
|
There was a problem hiding this comment.
I am fairly sure that this will break horribly if we attempt to load an exam object from the database that predates the v3 model.
Did you test this scenario? It would be good to retain backend tests for that case as well to give us assurance (noting that the mapping between versions happens in the frontend).
kolibri/core/exams/serializers.py
Outdated
| def to_representation(self, instance): | ||
| data = super().to_representation(instance) | ||
| if "question_sources" in data and data["question_sources"]: | ||
| first_question_source = data["question_sources"][0] |
There was a problem hiding this comment.
Seems like this conditionality could just be done based on the data_model_version rather than this sniff test?
|
Docs failure is unrelated to this PR, merging. |
Summary
References
closes #11580
Reviewer guidance
debug=trueonfunction useQuizCreationin the code.Testing checklist
PR process
Reviewer checklist
yarnandpip)