Linting issue in no-console

[thesujai]

Summary

Inserted no-console in rules that will warn if a conole.log is left without exception(the exception would be to disable it by using eslint-disable)
…

References

Fixes: #10208
…

Reviewers Guidance

If this is works, then i think a follow up would be to trace console.log from the code base

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b10.dev0_git.122.g18d590f0.pex
Windows Installer (EXE)	kolibri-0.16.0b10.dev0+git.122.g18d590f0-unsigned.exe
Debian Package	kolibri_0.16.0b10.dev0+git.122.g18d590f0-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b10.dev0+git.122.g18d590f0-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b10.dev0+git.122.g18d590f0-0.1.0-debug.apk
TAR file	kolibri-0.16.0b10.dev0+git.122.g18d590f0.tar.gz
WHL file	kolibri-0.16.0b10.dev0+git.122.g18d590f0-py2.py3-none-any.whl

[rtibbles]

Interestingly, the WARN still gives an error in our linting, I think maybe we can just set this to ERROR instead, as we don't seem to differentiate.

To merge this, we will need to fix the linting here. For most cases, we should use the core logging library, for an example of how it should be used, see here:

kolibri/kolibri/core/assets/src/utils/navComponents.js

Line 4 in dfe1a9d

const logging = logger.getLogger(__filename);

We can use this in all cases, except for the hashi and kolibri-tools packages, where we should add the relevant ignore comment for now.

[thesujai]

Interestingly, the WARN still gives an error in our linting, I think maybe we can just set this to ERROR instead, as we don't seem to differentiate.

To merge this, we will need to fix the linting here. For most cases, we should use the core logging library, for an example of how it should be used, see here:

kolibri/kolibri/core/assets/src/utils/navComponents.js

Line 4 in dfe1a9d

const logging = logger.getLogger(__filename);

We can use this in all cases, except for the hashi and kolibri-tools packages, where we should add the relevant ignore comment for now.

Hello @rtibbles, Thank you for the review.
I will make the changes and let you know

[thesujai]

Hello 👋🏽 @rtibbles, I made the suggested changes. Please review once
Read the docs are failing though 😕

[rtibbles]

Will review - don't worry about the read the docs build, this is not caused by your work, and has been fixed on the release branch!

[rtibbles]

Excellent work, thank you!