-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced isEmbeddedWebView with isAppContext #11715
Replaced isEmbeddedWebView with isAppContext #11715
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the way there, just two things to clean up!
kolibri/plugins/device/assets/src/modules/deviceInfo/handlers.js
Outdated
Show resolved
Hide resolved
kolibri/plugins/device/assets/src/modules/deviceInfo/handlers.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic got reversed in a couple of places, added suggestions to tweak.
kolibri/plugins/coach/assets/src/views/reports/ReportsControls.vue
Outdated
Show resolved
Hide resolved
kolibri/core/assets/src/views/ContentRenderer/DownloadButton.vue
Outdated
Show resolved
Hide resolved
Docs build failure is unrelated, merging! |
Summary
This Pr replaces the use of isEmbeddedWebView with isAppContext
References
#11689
…
Reviewer guidance
Do these changes make sense ?
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)