Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced isEmbeddedWebView with isAppContext #11715

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Jan 11, 2024

Summary

This Pr replaces the use of isEmbeddedWebView with isAppContext

  • Added an isAppContext computed property to the core useUser composable
  • Replaced every instance of isEmbeddedWebView with the isAppContext computed prop
  • Deleted unused isEmbeddedWebView and the constituent values from browserInfo.js

References

#11689

Reviewer guidance

Do these changes make sense ?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small labels Jan 11, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the way there, just two things to clean up!

kolibri/core/assets/src/utils/browserInfo.js Outdated Show resolved Hide resolved
@AllanOXDi AllanOXDi marked this pull request as ready for review January 11, 2024 18:13
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic got reversed in a couple of places, added suggestions to tweak.

@AllanOXDi AllanOXDi requested a review from rtibbles January 11, 2024 18:49
@rtibbles
Copy link
Member

Docs build failure is unrelated, merging!

@rtibbles rtibbles merged commit 8ad89be into learningequality:develop Jan 11, 2024
30 of 31 checks passed
@AllanOXDi AllanOXDi deleted the Bye-EmbeddedWebView branch January 12, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) DEV: frontend SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants