Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coach page specific sub nav toggling. #11744

Merged

Conversation

rtibbles
Copy link
Member

Summary

  • Before we finalized the updates to the AppBar for conditional display in certain app contexts, we had added it individually in the Coach plugin
  • This caused the coach top nav to not display in non-touch device contexts in app mode
  • Cleans this up and removes unused prop

Reviewer guidance

Run the Mac App or run the local development app server command
Go to the coach plugin
Ensure that once you have selected a facility and a class the top nav displays


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jan 18, 2024
@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small labels Jan 18, 2024
@pcenov pcenov self-requested a review January 19, 2024 12:56
@radinamatic
Copy link
Member

Running fine with the app bar displaying correctly with dev environment in app context:

2024-01-19_14-16-27

@radinamatic
Copy link
Member

Will approve after @pcenov confirms the fix on the macOS.

Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radinamatic I confirm that the top navigation is displayed in the mac app as well.

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go! 💯 :shipit:

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up looks good to me! Thanks @rtibbles

@rtibbles rtibbles merged commit a579274 into learningequality:release-v0.16.x Jan 19, 2024
34 checks passed
@rtibbles rtibbles deleted the coach_app_nav_bar branch January 19, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants