-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove coach page specific sub nav toggling. #11744
Remove coach page specific sub nav toggling. #11744
Conversation
Build Artifacts
|
Will approve after @pcenov confirms the fix on the macOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radinamatic I confirm that the top navigation is displayed in the mac app as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual QA passes, good to go! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean up looks good to me! Thanks @rtibbles
Summary
Reviewer guidance
Run the Mac App or run the local development app server command
Go to the coach plugin
Ensure that once you have selected a facility and a class the top nav displays
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)