Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mac tests to run on Python 3.10 #11753

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

rtibbles
Copy link
Member

Summary

The Mac App is built against Python 3.10, but currently our Mac tests run on Python 3.6
Updates the Python version for Mac tests to Python 3.10 instead.

References

https://github.com/learningequality/kolibri-app/blob/main/.github/workflows/build_mac.yml#L55

Reviewer guidance

Do the Python tests still pass?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment SIZE: very small labels Jan 19, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mac tests on 3.10 pass

@marcellamaki
Copy link
Member

Since Python unit tests on Mac OS (3.6), merging without tests passing, as they will not run any more, with this update

@marcellamaki marcellamaki merged commit dcce356 into release-v0.16.x Feb 27, 2024
39 checks passed
@rtibbles rtibbles deleted the rtibbles-patch-1 branch March 6, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: dev-ops Continuous integration & deployment SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants