fix: os_user unnecessary password field

[ThEditor]

Summary

Resets usernameSubmittedWithoutPassword back to false on clearUser (executed when user goes back using "Change User")

References

Closes #11777

Reviewer guidance

1. Running Kolibri locally [not in app_mode], create a user with a password (let's call this "pw_user")
2. Stop your Kolibri server, but maintain the same KOLIBRI_HOME folder
   Run Kolibri locally using (https://kolibri-dev.readthedocs.io/en/develop/getting_started.html#running-in-app-mode). (let's call this "os_user")
3. Sign out. You should now see both "pw_user" and "os_user" available to select in the sign in page
   Select "pw_user". You should be directed to the next step, where you enter your password. Do not sign in. Go back via "Change User"
4. Select "os_user". You should not see any password field show up and sign-in should happen automatically.

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[ThEditor]

@marcellamaki any updates on it?

[MisRob]

Hi @ThEditor, thanks for the contribution! We have a queue of pull requests. Generally, a review may take up to two weeks.

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.1.dev0_git.20240224015516.pex
Windows Installer (EXE)	kolibri-0.16.1.dev0+git.20240224015516-unsigned.exe
Debian Package	kolibri_0.16.1.dev0+git.20240224015516-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.1.dev0+git.20240224015516-0.4.0.dmg
Android Package (APK)	kolibri-0.16.1.dev0+git.20240224015516-0.1.0-debug.apk
TAR file	kolibri-0.16.1.dev0+git.20240224015516.tar.gz
WHL file	kolibri-0.16.1.dev0+git.20240224015516-py2.py3-none-any.whl

[marcellamaki]

Hi @ThEditor - I apologize for the delay in following up on this PR. The code changes look good and I've done manual QA to confirm. Thank you for your contribution here!

[ThEditor]

Its fine, no worries. Thanks for approving the PR. :D

[marcellamaki]

I'm just rerunning the Python checks, and if it sorts itself out, this will be good to merge, and I'll do that later today :)

[rtibbles]

No need to change the code here, but flagging that the issue this is fixing is targeted for Planned Patch 1 - this means that this PR should be targeted at the release-v0.16.x branch, not develop!

For details on how to do a rebase from one to another, please see here: https://kolibri-dev.readthedocs.io/en/develop/howtos/rebasing_a_pull_request.html

Note, I have retarged the pull request already, so you just need to do the rebase and force push to update the PR branch.

[ThEditor]

I've rebased the PR, does it look correct?

[radinamatic]

From the manual QA point of view we're struggling to find the real-world scenario this PR is supposed to fix... Is it only replicable in the dev environment, or there is some angle we're missing when using built assets?

[pcenov]

Thanks @ThEditor - I confirm that the issue described in #11777 is now fixed. cc @marcellamaki

[radinamatic]

Manual QA passed, good to go! 💯 🚀

[marcellamaki]

Thank you for retargeting this PR @ThEditor and for your patience!

Requested change - rebasing the PR - has been addressed