Fix import duplicate usernames

[nick2432]

Summary

This pull request introduces a modification to the get_username method, enabling case-insensitive checking for duplicate usernames.

Changes made

Updated the get_username method to convert usernames to lowercase before checking for duplicates.
Ensured that usernames with different letter cases are treated as the same to prevent case-related duplicates.

Issue Resolved

Fixes #11890

##Screenshots

2024-02-18.17-00-56.mp4

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.1.dev0_git.20240224162307.pex
Windows Installer (EXE)	kolibri-0.16.1.dev0+git.20240224162307-unsigned.exe
Debian Package	kolibri_0.16.1.dev0+git.20240224162307-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.1.dev0+git.20240224162307-0.4.0.dmg
Android Package (APK)	kolibri-0.16.1.dev0+git.20240224162307-0.1.0-debug.apk
TAR file	kolibri-0.16.1.dev0+git.20240224162307.tar.gz
WHL file	kolibri-0.16.1.dev0+git.20240224162307-py2.py3-none-any.whl

[radinamatic]

@nick2432 We'll proceed with the manual QA, please try to fix the linting errors in the meantime.

[pcenov]

Hi @nick2432, there's one more case to handle here - if the username is already existing in the facility and I attempt to import several duplicated usernames or just the same username as the one which is already in the facility, you are now checking that they are duplicated but you are still allowing one of the usernames to be imported:

2024-02-19_11-19-23.mp4

It shouldn't be possible to import a duplicated username which is without a UUID.

[akolson]

Hi @nick2432, the current changes makes make sense to me. I will however hold off the approval until the feedback from @pcenov has been added. Thanks. Also, noting that your most recent commit seems to have brought in a really huge number of changes. Is this intended?

[nick2432]

Hi @nick2432, the current changes makes make sense to me. I will however hold off the approval until the feedback from @pcenov has been added. Thanks. Also, noting that your most recent commit seems to have brought in a really huge number of changes. Is this intended?

no

[akolson]

Please be sure to let us know how we can help in case you encounter any challenges while reverting the changes. Thanks

[rtibbles]

Retargeting this to release-v0.16.x as the issue is for Planned Patch 1.

[rtibbles]

Hi @nick2432 - sorry, after you sorted out your previous rebase woes, the retarget is going to give you more issues.

Could you please rebase this onto release-v0.16.x? See here for instructions: https://github.com/learningequality/kolibri/blob/develop/docs/howtos/rebasing_a_pull_request.md

[nick2432]

Hey @pcenov , could you please check my new changes?

[pcenov]

Thanks @nick2432 - I confirm that now it's not possible to import duplicate usernames.

[akolson]

Hi @nick2432. This looks correct to me. It would however be nice to add some tests to https://github.com/learningequality/kolibri/blob/7fba0d2a8edd9e2edda5df9ae196865a8c624172/kolibri/core/auth/test/test_bulk_import.py as as well covering the scenarios that @pcenov raised. Thanks again

[nick2432]

Hi @nick2432. This looks correct to me. It would however be nice to add some tests to https://github.com/learningequality/kolibri/blob/7fba0d2a8edd9e2edda5df9ae196865a8c624172/kolibri/core/auth/test/test_bulk_import.py as as well covering the scenarios that @pcenov raised. Thanks again

I will add the tests and have resolved the scenarios raised by @pcenov.

[akolson]

Thanks @nick2432.

[rtibbles]

Also worth noting that there is a test failure now of an existing test, might be worth checking if something has broken, or if an assumption of the test is now being violated:

kolibri.core.auth.test.test_bulk_import.ImportTestCase testMethod=test_asterisk_in_password

[nick2432]

@akolson @rtibbles , I have added the tests and resolved the test failure.

[akolson]

LGTM. Thanks for seeing this through @nick2432.

[akolson]

Assigning this to Marcella for merge purposes.