Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure noarch dir is added to path when abi3 c extensions are used. #11905

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Ensures we use bundled Kolibri packages when C extension are active to prevent version conflicts

References

Fixes error reported in #11895 (comment)

Reviewer guidance

Set up a Python 2.7 virtualenv.
Run make staticdeps and make staticdeps-cext.

Set up a Python 3.11 virtualenv. Install kolibri and all dependencies into the virtualenv. Install PyOpenSSL version 23.0.0 into the virtual env.

Run kolibri, ensure that it does not give the error reported above (or any errors, hopefully!).


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and reporter says it works #11895 (comment)

@bjester bjester merged commit 0098f7e into learningequality:release-v0.16.x Feb 20, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants