tests: Complete the test suite for TriesOverview Component
#11906
Conversation
| return this.pastTries.length | ||
| ? this.pastTries.find(t => t.correct === this.maxQuestionsCorrect).time_spent | ||
| : null; |
There was a problem hiding this comment.
If the length of pastTries is not 0, then we are guaranteed to have a try object as the result of line 121 as this.maxQuestionsCorrect would be returning the score of the same (and thus we would always find it).
If not, then we can return the same as null.
There was a problem hiding this comment.
@EshaanAgg sorry, I just noticed that If, for some reason, there is a corrupted object, and a try.correct is undefined, then Math.max will give NaN, and the .find will be null. It is better to add the null check, as before, in case anything can happen with the tries objects.
There was a problem hiding this comment.
Okay sir, got that! Will revert these changes.
Build Artifacts
|
| }); | ||
|
|
||
| test('renders the best score as 0 when there are no past tries', () => { | ||
| renderComponent(); |
There was a problem hiding this comment.
We can pass the pastTries explicitly as an empty array and the totalQuestions value.
There was a problem hiding this comment.
Got it! Thanks for the review!
There was a problem hiding this comment.
It seems that we forgot to update the code here 😅 I meant to add something like:
renderComponent({ pastTries: [] });There was a problem hiding this comment.
My bad! I totally missed this comment. Will update.
Summary
TriesOverviewComponent withVTLnullvalues.I might be misunderstanding some functionality or missing out on some edge cases, so a second set of eyes would be helpful!
References
Parent Issue
Testing checklist
PR process
Reviewer checklist
yarnandpip)